Skip to content

Allow the application to pass additional options to validate_id_token#63

Merged
maennchen merged 3 commits intoerlef:mainfrom
filmor:allow-override-validate-opts
Dec 12, 2025
Merged

Allow the application to pass additional options to validate_id_token#63
maennchen merged 3 commits intoerlef:mainfrom
filmor:allow-override-validate-opts

Conversation

@filmor
Copy link
Contributor

@filmor filmor commented Dec 4, 2025

For example to change the behaviour with regard to the azp claim.

maennchen
maennchen previously approved these changes Dec 4, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build d1f3ab5c695f58539f8dcafe119e436f94cd36c4-PR-63

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.423%

Totals Coverage Status
Change from base Build e04c17942975c37a5eb83ea89b769bb625be94d7: 0.0%
Covered Lines: 189
Relevant Lines: 194

💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 4, 2025

Pull Request Test Coverage Report for Build 68c23d449f471d25b35e154bdef0a1754f8f820f-PR-63

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.423%

Totals Coverage Status
Change from base Build a5a8e4e4b1e7700cca64565a732fc635e8285a84: 0.0%
Covered Lines: 189
Relevant Lines: 194

💛 - Coveralls

@maennchen
Copy link
Member

@filmor It looks like we forgot to do the nonce_or_opts change in the Elixir side of things with the azp PR.

@filmor
Copy link
Contributor Author

filmor commented Dec 4, 2025

This should be fixed with erlef/oidcc#490

@maennchen
Copy link
Member

@filmor I'll do a release in the next few days for oidcc. Then we can bump the requirement here and merge :)

@maennchen
Copy link
Member

@filmor I released 3.7.0

@filmor filmor force-pushed the allow-override-validate-opts branch from 01ead47 to b6ceccd Compare December 12, 2025 09:10
@filmor filmor force-pushed the allow-override-validate-opts branch from b6ceccd to 8dd430e Compare December 12, 2025 10:28
@maennchen maennchen enabled auto-merge (squash) December 12, 2025 10:45
@maennchen maennchen disabled auto-merge December 12, 2025 11:23
@maennchen maennchen merged commit c2369b0 into erlef:main Dec 12, 2025
14 checks passed
@filmor filmor deleted the allow-override-validate-opts branch December 12, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants