Skip to content

Support mise.toml as version-file (input)#415

Merged
paulo-ferraz-oliveira merged 22 commits intoerlef:mainfrom
dinokovac-river:mise-toml
Mar 9, 2026
Merged

Support mise.toml as version-file (input)#415
paulo-ferraz-oliveira merged 22 commits intoerlef:mainfrom
dinokovac-river:mise-toml

Conversation

@dinokovac-river
Copy link
Contributor

@dinokovac-river dinokovac-river commented Mar 3, 2026

This is the continuation of the work in #374.

We want to be able to support mise version files which are in TOML format. The code autodetects the format by extension so the usage doesn't really change. The README was updated.

@dinokovac-river dinokovac-river changed the title Mise toml Support mise.toml Mar 3, 2026
@dinokovac-river dinokovac-river changed the title Support mise.toml Support mise.toml Mar 3, 2026
@starbelly
Copy link
Member

I think I'm good on this unless there's any feedback @paulo-ferraz-oliveira might be interested in giving.

Copy link
Collaborator

@paulo-ferraz-oliveira paulo-ferraz-oliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good direction. Thanks for the contribution. I just have a question or two around the file name, then we should be good to go.

Co-authored-by: Paulo F. Oliveira <paulo.ferraz.oliveira@gmail.com>
@paulo-ferraz-oliveira
Copy link
Collaborator

You'll probably need to run npm run build-dist, but feel free to do that at the same time you update the debug message. Everything else looks good.

@dinokovac-river
Copy link
Contributor Author

Should be good to go now, assuming CI goes green.

@paulo-ferraz-oliveira
Copy link
Collaborator

Might be you forgot to run npm run build-dist?

@dinokovac-river
Copy link
Contributor Author

Might be you forgot to run npm run build-dist?

Sorry about that, I was sure I did! 😓

@paulo-ferraz-oliveira
Copy link
Collaborator

Re-running CI. I'm just waiting for ✅ since I have no further input on the implementation.

@paulo-ferraz-oliveira
Copy link
Collaborator

Could you rebase and push again? This dist/index.js stuff is a PITA.

@dinokovac-river
Copy link
Contributor Author

Could you rebase and push again? This dist/index.js stuff is a PITA.

It really is! 😅

Now up to date with upstream master, by way of merge. I can also rebase if needed, but I guess we can just squash the PR into a single commit to make it easier 🙏

@paulo-ferraz-oliveira paulo-ferraz-oliveira merged commit 98c13a9 into erlef:main Mar 9, 2026
71 checks passed
@paulo-ferraz-oliveira
Copy link
Collaborator

Merged. Thanks.

@paulo-ferraz-oliveira paulo-ferraz-oliveira changed the title Support mise.toml Support mise.toml as version-file (input) Mar 9, 2026
@paulo-ferraz-oliveira
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants