Skip to content

fix: Swap ModelSupportsVaneHorizontal and ModelSupportsVaneVertical #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erwindouna merged 2 commits into from
Sep 23, 2025
Merged

fix: Swap ModelSupportsVaneHorizontal and ModelSupportsVaneVertical #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36b1ef7
fix: Swap ModelSupportsVaneHorizontal and ModelSupportsVaneVertical
Sander0542 Aug 15, 2025
1a886c5
fix: Add comment detailing property swap
Sander0542 Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/pymelcloud/ata_device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,8 @@ def vane_horizontal_positions(self) -> Optional[List[str]]:
if self._device_conf.get("HideVaneControls", False):
return []
device = self._device_conf.get("Device", {})
if not device.get("ModelSupportsVaneHorizontal", False):
# ModelSupportsVaneVertical and ModelSupportsVaneHorizontal are swapped in the API
if not device.get("ModelSupportsVaneVertical", False):
return []

positions = [
Expand Down Expand Up @@ -351,7 +352,8 @@ def vane_vertical_positions(self) -> Optional[List[str]]:
if self._device_conf.get("HideVaneControls", False):
return []
device = self._device_conf.get("Device", {})
if not device.get("ModelSupportsVaneVertical", False):
# ModelSupportsVaneHorizontal and ModelSupportsVaneVertical are swapped in the API
if not device.get("ModelSupportsVaneHorizontal", False):
return []

positions = [
Expand Down