Chances remastered#27
Merged
es3n1n merged 2 commits intoes3n1n:devfrom Apr 3, 2025
lustman:chances-remastered
Merged
Conversation
es3n1n
requested changes
Apr 3, 2025
Owner
es3n1n
left a comment
es3n1n
left a comment
There was a problem hiding this comment.
Other than that LGTM, thank you!
Not sure why I went with 30% default value though 😅
Co-authored-by: Arsenii es3n1n <me@es3n.in>
es3n1n
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#25
I believe the default chance should be 100%, and it should be reduced only when required(e.g. transformers conflict).