Logarithmic axes scaling fix#163
Open
nkaraman wants to merge 2 commits intoeseifert:masterfrom
nkaraman:master
Open
Logarithmic axes scaling fix#163nkaraman wants to merge 2 commits intoeseifert:masterfrom nkaraman:master
nkaraman wants to merge 2 commits intoeseifert:masterfrom
nkaraman:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
In some cases scaling with logarithmic axes behaved strange. When you move in chart or scale it fixes the axes in scale of 0 to 1.
There is no way to get out of that state (only restart an app)
Reason:
In LogarithmicRenderer2D.java:worldToView operation Math.log10(val) with val=0 gives you Infinite.
This mess up computations.
Proposed solution:
Limit computation results to 0 if result is infinite.