Skip to content

fix has_quote detection to handle free-form string values in header cards#421

Merged
beckermr merged 9 commits intoesheldon:masterfrom
dstndstn:free-form-string
Feb 20, 2025
Merged

fix has_quote detection to handle free-form string values in header cards#421
beckermr merged 9 commits intoesheldon:masterfrom
dstndstn:free-form-string

Conversation

@dstndstn
Copy link
Copy Markdown
Contributor

This fixes #420

Copy link
Copy Markdown
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax?

@esheldon
Copy link
Copy Markdown
Owner

Thanks Dustin. Is there still an issue with the integer conversions?

Copy link
Copy Markdown
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add an entry into the changelog and then this one is good to go! Thank you!

Copy link
Copy Markdown
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dstndstn
Copy link
Copy Markdown
Contributor Author

Thanks Dustin. Is there still an issue with the integer conversions?

Hah, oh yeah, what I thought was the original problem :) They get handled as intended: saved as strings.

QID     = '55700500000000071282' / 
QOBSEQID= '55301400000000319065' / 
QICSEQID= '55351200000000356039' / 
QOBITER =                   11 / 
QOFFID  = '10000000000000000001' / 

@beckermr beckermr merged commit 94595f1 into esheldon:master Feb 20, 2025
13 checks passed
@dstndstn
Copy link
Copy Markdown
Contributor Author

Thanks!!

@dstndstn dstndstn deleted the free-form-string branch February 20, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error reading very large integer-looking values in headers

3 participants