fix has_quote detection to handle free-form string values in header cards#421
Merged
beckermr merged 9 commits intoesheldon:masterfrom Feb 20, 2025
Merged
fix has_quote detection to handle free-form string values in header cards#421beckermr merged 9 commits intoesheldon:masterfrom
beckermr merged 9 commits intoesheldon:masterfrom
Conversation
beckermr
reviewed
Feb 20, 2025
Owner
|
Thanks Dustin. Is there still an issue with the integer conversions? |
beckermr
requested changes
Feb 20, 2025
Collaborator
beckermr
left a comment
There was a problem hiding this comment.
Let's add an entry into the changelog and then this one is good to go! Thank you!
Contributor
Author
Hah, oh yeah, what I thought was the original problem :) They get handled as intended: saved as strings. |
Contributor
Author
|
Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #420