Skip to content

feat!: drop eslint v8 support #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat!: drop eslint v8 support #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,6 @@ jobs:
- run: npm install
- run: npm run lint

eslint8:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: "lts/*"
- run: npm install
- run: npm install --save-dev eslint@8
- run: npm test

test-remote:
name: eslint-remote-tester
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"typescript": "^5.7.2"
},
"peerDependencies": {
"eslint": ">=8.23.0"
"eslint": ">=9.0.0"
},
"engines": {
"node": "^18.18.0 || ^20.9.0 || >=21.1.0"
Expand Down
15 changes: 0 additions & 15 deletions tests/lib/eslint-rule-tester.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion tests/lib/rules/consistent-output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/consistent-output');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

const ERROR = { messageId: 'missingOutput', type: 'ObjectExpression' };

Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/fixer-return.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/fixer-return');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

// ------------------------------------------------------------------------------
// Tests
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/meta-property-ordering.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/meta-property-ordering');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

// ------------------------------------------------------------------------------
// Tests
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-deprecated-context-methods.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/no-deprecated-context-methods');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

// ------------------------------------------------------------------------------
// Tests
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-deprecated-report-api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/no-deprecated-report-api');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

// ------------------------------------------------------------------------------
// Tests
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-identical-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/no-identical-tests');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

const ERROR_OBJECT_TEST = { messageId: 'identical', type: 'ObjectExpression' };
const ERROR_STRING_TEST = { messageId: 'identical', type: 'Literal' };
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-meta-replaced-by.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/no-meta-replaced-by');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

// ------------------------------------------------------------------------------
// Tests
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-meta-schema-default.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/no-meta-schema-default');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

// ------------------------------------------------------------------------------
// Tests
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-missing-message-ids.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/no-missing-message-ids');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

// ------------------------------------------------------------------------------
// Tests
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-missing-placeholders.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/no-missing-placeholders');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

/**
* Create an error for the given key
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-only-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/no-only-tests');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

// ------------------------------------------------------------------------------
// Tests
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-property-in-node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;
const path = require('path');
const rule = require('../../../lib/rules/no-property-in-node');

Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-unused-message-ids.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/no-unused-message-ids');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

// ------------------------------------------------------------------------------
// Tests
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-unused-placeholders.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/no-unused-placeholders');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

/**
* Create an error for the given key
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-useless-token-range.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/no-useless-token-range');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

/**
* Wraps a code sample as an eslint rule
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/prefer-message-ids.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/prefer-message-ids');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

// ------------------------------------------------------------------------------
// Tests
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/prefer-object-rule.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/prefer-object-rule');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

// ------------------------------------------------------------------------------
// Tests
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/prefer-output-null.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/prefer-output-null');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

const ERROR = { messageId: 'useOutputNull', type: 'Property' };

Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/prefer-placeholders.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/prefer-placeholders');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

// ------------------------------------------------------------------------------
// Tests
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/prefer-replace-text.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/prefer-replace-text');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

// ------------------------------------------------------------------------------
// Tests
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/report-message-format.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/report-message-format');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

// ------------------------------------------------------------------------------
// Tests
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/require-meta-default-options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

const rule = require('../../../lib/rules/require-meta-default-options');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

const ruleTester = new RuleTester({
languageOptions: { sourceType: 'commonjs' },
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/require-meta-docs-description.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/require-meta-docs-description');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

// ------------------------------------------------------------------------------
// Tests
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/require-meta-docs-recommended.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

const rule = require('../../../lib/rules/require-meta-docs-recommended');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

const ruleTester = new RuleTester({
languageOptions: { sourceType: 'commonjs' },
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/require-meta-docs-url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
// Requirements
// -----------------------------------------------------------------------------

const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;
const rule = require('../../../lib/rules/require-meta-docs-url');

// -----------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/require-meta-fixable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/require-meta-fixable');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

// ------------------------------------------------------------------------------
// Tests
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/require-meta-has-suggestions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/require-meta-has-suggestions');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

// ------------------------------------------------------------------------------
// Tests
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/require-meta-schema-description.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/require-meta-schema-description');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

// ------------------------------------------------------------------------------
// Tests
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/require-meta-schema.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/require-meta-schema');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

// ------------------------------------------------------------------------------
// Tests
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/require-meta-type.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/require-meta-type');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

// ------------------------------------------------------------------------------
// Tests
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/test-case-property-ordering.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/test-case-property-ordering');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

// ------------------------------------------------------------------------------
// Tests
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/test-case-shorthand-strings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
// ------------------------------------------------------------------------------

const rule = require('../../../lib/rules/test-case-shorthand-strings');
const RuleTester = require('../eslint-rule-tester').RuleTester;
const RuleTester = require('eslint').RuleTester;

/**
* Returns the code for some valid test cases
Expand Down