Skip to content

Conversation

michaelfaith
Copy link
Contributor

@michaelfaith michaelfaith commented Jun 20, 2025

This change removes support for legacy rc-based configs, and moves minimum supported version to 9.0. I've also removed the deprecated /configs entry point. Please use the plugin's configs object.

Contributes to #505

This change removes support for legacy rc-based configs, and moves minimum supported version to 9.0.  I've also removed the deprecated `/configs` entry point.
@michaelfaith michaelfaith marked this pull request as ready for review June 20, 2025 22:47
@michaelfaith michaelfaith mentioned this pull request Jun 20, 2025
@bmish
Copy link
Member

bmish commented Jun 20, 2025

Can you cherry-pick my commit from this PR to include the RuleTester update? Then I can close my PR.

@bmish bmish added the BREAKING CHANGE This change will require a major version bump label Jun 20, 2025
@michaelfaith
Copy link
Contributor Author

michaelfaith commented Jun 20, 2025

Your PR removed our RuleTester, but with the vitest change (which I believe was still in PR, when your change went up), we still need to attach vitest's functions to RuleTester. So I removed the v8 specific logic from it, but left the vitest augmentation. I think this will cover what was in your change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR removed our RuleTester, but with the vitest change (which I believe was still in PR, when your change went up), we still need to attach vitest's functions to RuleTester. So I removed the v8 specific logic from it, but left the vitest augmentation. I think this will cover what was in your change?

@michaelfaith I just pushed this change to solve that so rule test files can use the standard RuleTester import. Look good?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! That's much cleaner. Thanks.

@bmish bmish changed the title feat!: remove eslint v8 support feat!: remove eslint v8 / eslintrc support and remove flat/ prefix from configs Jun 20, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's some more context about the config names btw:

I think the current plan to just drop ESLint v8 / eslintrc now is fine.

},
],
import eslintPlugin from 'eslint-plugin-eslint-plugin';
import packageMetadata from './package.json' with { type: 'json' };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: 130:29 error Can't resolve './package.json' in '/home/runner/work/eslint-plugin-eslint-plugin/eslint-plugin-eslint-plugin/docs/rules/require-meta-docs-url.md' n/no-missing-import

You can disable that lint rule for this file if necessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I had 'n/no-missing-imports' instead of 'n/no-missing-import' doh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

Copy link
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmish bmish merged commit 03cf3d7 into eslint-community:main Jun 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BREAKING CHANGE This change will require a major version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants