Skip to content

feat: update eslint-plugin-node + update configs#24

Merged
MichaelDeBoey merged 2 commits intoalphafrom
patch-10
Oct 17, 2022
Merged

feat: update eslint-plugin-node + update configs#24
MichaelDeBoey merged 2 commits intoalphafrom
patch-10

Conversation

@MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Oct 16, 2022 •
edited
Loading

Re-submission of mysticatea#42

BREAKING CHANGE: +node, es5, es2015, es2016, es2017, es2018, es2019, es2020, es2021 & es2022 configs now have extra rules from eslint-plugin-node

@MichaelDeBoey MichaelDeBoey requested a review from a team October 16, 2022 18:38
@MichaelDeBoey MichaelDeBoey self-assigned this Oct 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2022 •
edited
Loading

Codecov Report

Base: 97.17% // Head: 97.17% // No change to project coverage 👍

Coverage data is based on head (0f90860) compared to base (0f90860).
Patch has no changes to coverable lines.

❗ Current head 0f90860 differs from pull request most recent head 47a72e2. Consider uploading reports for the commit 47a72e2 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files          39       39           
  Lines         390      390           
=======================================
  Hits          379      379           
  Misses         11       11

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MichaelDeBoey
Copy link
Member Author

MichaelDeBoey commented Oct 16, 2022

@eslint-community/eslint-tsc @eslint-community/core-team @eslint-community/mysticatea-eslint-plugin Since this plugin is adhering the same semantic versioning policy as ESLint, adding new rules to a plugin would be a breaking change, so this PR would need to be released in a major release I guess?

@MichaelDeBoey MichaelDeBoey requested review from a team October 16, 2022 18:55
@MichaelDeBoey MichaelDeBoey marked this pull request as draft October 16, 2022 18:55
ota-meshi
ota-meshi requested changes Oct 16, 2022
View reviewed changes
@MichaelDeBoey MichaelDeBoey changed the base branch from main to alpha October 16, 2022 23:15
@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review October 17, 2022 00:57
@MichaelDeBoey
feat: update eslint-plugin-node + update configs
03784bb 
BREAKING CHANGE: `+node`, `es5`, `es2015`, `es2016`, `es2017`, `es2018`, `es2019`, `es2020`, `es2021` & `es2022` configs now have extra rules from `eslint-plugin-node`
@MichaelDeBoey
chore: fix ESLint errors
d3357e6
@MichaelDeBoey MichaelDeBoey merged commit bbaf218 into alpha Oct 17, 2022
@MichaelDeBoey MichaelDeBoey deleted the patch-10 branch October 17, 2022 17:55
@github-actions
Copy link

github-actions bot commented Oct 17, 2022

🎉 This PR is included in version 15.0.0-alpha.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Oct 18, 2022

🎉 This PR is included in version 15.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Oct 18, 2022

🎉 This PR is included in version 15.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees

@MichaelDeBoey MichaelDeBoey

Labels

hacktoberfest-accepted released on @alpha released on @beta released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelDeBoey @codecov-commenter @ota-meshi