Skip to content

fix!: mixed-esm-and-cjs should only add the deviating type aside from base #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix!: mixed-esm-and-cjs should only add the deviating type aside from base #300

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73d1099
fix: `mixed-esm-and-cjs` adds only deviating type
voxpelli Jun 14, 2024
145dbec
feat: add and export new `recommended-env`
voxpelli Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/configs/recommended.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,5 @@ module.exports.eslintrc = {
}

module.exports.flat = recommendedConfig.flat

module.exports.isModule = isModule
7 changes: 4 additions & 3 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,10 @@ const plugin = {
"flat/recommended-script": { ...cjsConfig.flat },
"flat/recommended": { ...recommendedConfig.flat },
"flat/mixed-esm-and-cjs": [
{ files: ["**/*.js"], ...recommendedConfig.flat },
{ files: ["**/*.mjs"], ...esmConfig.flat },
{ files: ["**/*.cjs"], ...cjsConfig.flat },
{ ...recommendedConfig.flat },
recommendedConfig.isModule
? { files: ["**/*.cjs"], ...cjsConfig.flat }
: { files: ["**/*.mjs"], ...esmConfig.flat },
],
},
}
Expand Down