Skip to content

docs: fix typo #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: fix typo #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,8 @@ For [Shareable Configs](https://eslint.org/docs/latest/developer-guide/shareable
| [no-extraneous-import](docs/rules/no-extraneous-import.md) | disallow `import` declarations which import extraneous modules | 🟢 ✅ | | |
| [no-extraneous-require](docs/rules/no-extraneous-require.md) | disallow `require()` expressions which import extraneous modules | 🟢 ✅ | | |
| [no-hide-core-modules](docs/rules/no-hide-core-modules.md) | disallow third-party modules which are hiding core modules | | | ❌ |
| [no-missing-import](docs/rules/no-missing-import.md) | disallow `import` declarations which import non-existence modules | 🟢 ✅ | | |
| [no-missing-require](docs/rules/no-missing-require.md) | disallow `require()` expressions which import non-existence modules | 🟢 ✅ | | |
| [no-missing-import](docs/rules/no-missing-import.md) | disallow `import` declarations which import non-existing modules | 🟢 ✅ | | |
| [no-missing-require](docs/rules/no-missing-require.md) | disallow `require()` expressions which import non-existing modules | 🟢 ✅ | | |
| [no-mixed-requires](docs/rules/no-mixed-requires.md) | disallow `require` calls to be mixed with regular variable declarations | | | |
| [no-new-require](docs/rules/no-new-require.md) | disallow `new` operators with calls to `require` | | | |
| [no-path-concat](docs/rules/no-path-concat.md) | disallow string concatenation with `__dirname` and `__filename` | | | |
Expand Down
2 changes: 1 addition & 1 deletion docs/rules/no-missing-import.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Disallow `import` declarations which import non-existence modules (`n/no-missing-import`)
# Disallow `import` declarations which import non-existing modules (`n/no-missing-import`)

💼 This rule is enabled in the following [configs](https://github.com/eslint-community/eslint-plugin-n#-configs): 🟢 `recommended-module`, ✅ `recommended-script`.

Expand Down
2 changes: 1 addition & 1 deletion docs/rules/no-missing-require.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Disallow `require()` expressions which import non-existence modules (`n/no-missing-require`)
# Disallow `require()` expressions which import non-existing modules (`n/no-missing-require`)

💼 This rule is enabled in the following [configs](https://github.com/eslint-community/eslint-plugin-n#-configs): 🟢 `recommended-module`, ✅ `recommended-script`.

Expand Down
2 changes: 1 addition & 1 deletion lib/rules/no-missing-import.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ module.exports = {
meta: {
docs: {
description:
"disallow `import` declarations which import non-existence modules",
"disallow `import` declarations which import non-existing modules",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 This does not read quite right to me either, Here are some options that sound better to my ear:

Suggested change
"disallow `import` declarations which import non-existing modules",
"disallow `import` declarations which import non-existent modules",
Suggested change
"disallow `import` declarations which import non-existing modules",
"disallow `import` declarations which import missing modules",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a native English speaker, but non-existing sounds good to me.

I would go for missing though as that resolves all the "it doesn't sound right" problems in this case

recommended: true,
url: "https://github.com/eslint-community/eslint-plugin-n/blob/HEAD/docs/rules/no-missing-import.md",
},
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/no-missing-require.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ module.exports = {
meta: {
docs: {
description:
"disallow `require()` expressions which import non-existence modules",
"disallow `require()` expressions which import non-existing modules",
recommended: true,
url: "https://github.com/eslint-community/eslint-plugin-n/blob/HEAD/docs/rules/no-missing-require.md",
},
Expand Down