feat: add prefer-global/timers rule#515
Merged
aladdin-add merged 1 commit intoeslint-community:masterfrom Feb 15, 2026
Merged
Conversation
aladdin-add
reviewed
Feb 10, 2026
| setInterval: { [READ]: true }, | ||
| setTimeout: { [READ]: true }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
To avoid repetition, we can define a variable first and then reference it:
const timers = {
clearImmediate: { [READ]: true },
clearInterval: { [READ]: true },
clearTimeout: { [READ]: true },
setImmediate: { [READ]: true },
setInterval: { [READ]: true },
setTimeout: { [READ]: true },
};
const traceMap = {
globals: timers,
modules: {
timers: timers,
"node:timers": timers,
},
};
aladdin-add
approved these changes
Feb 15, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
This PR introduces the
prefer-global/timersrule to enforce consistent usage of timer functions—includingsetImmediate,setInterval,setTimeout, and theirclear*counterparts—as either global variables or as imports from thenode:timersmodule.What changes did you make? (Give an overview)
prefer-global/cryptoruleRelated Issues
Closes #339
Is there anything you'd like reviewers to focus on?