Skip to content

Add type to fixable rules #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add type to fixable rules #186

wants to merge 1 commit into from

Conversation

sk-
Copy link

@sk- sk- commented Apr 12, 2020

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Other, please explain:

What changes did you make? (Give an overview)
Add type to fixable rules. Fixes #152.

Note that in this PR I also clean up the rule param-names, that was wrongly documented to be fixable.

Fixes #152.

Note that in this PR I also cleaned up the rule param-names, that was wronlgy documented to be fixable.
@brettz9
Copy link
Member

brettz9 commented May 19, 2020

I'd ask if you could close this in favor of #185 which adds meta.type for all rules (including no-new-statics, though as a "problem" since it causes errors), and in favor of #183 which also removes the fixable: 'code' statement in param-names.js as does this PR (while also updating the no-new-statics docs to make mention that that rule is fixable while updating param-names docs to update that rule is not fixable).

@sk-
Copy link
Author

sk- commented May 19, 2020

Sure, sorry I didn't take a look at your Prs.

@sk- sk- closed this May 19, 2020
@brettz9
Copy link
Member

brettz9 commented May 19, 2020

No worries! All good! And good to know others are on the same page...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the new rule meta.type property
2 participants