fix: make no-invalid-properties var() case-insensitive #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
reviewed
Aug 9, 2025
| @@ -592,5 +618,134 @@ ruleTester.run("no-invalid-properties", rule, { | |||
| }, | |||
| ], | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
CSS variables --my-color is not case sensitive, can we please add a few cases to verify the rule is working as expected for them?
There was a problem hiding this comment.
They are case-sensitive. From MDN:
Note: Custom property names are case sensitive —
--my-colorwill be treated as a separate custom property to--My-color.
There was a problem hiding this comment.
Ah sorry! I meant case sensitive only, just add a case where it is working as expected
snitin315
added
accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This PR fixes a bug in the
no-invalid-propertiesrule wherevar()was matched case-sensitively, causing mixed/uppercase usages likeVAR()orVar()to be missed. CSS function names are ASCII case-insensitive, so these should be treated equivalently.What changes did you make? (Give an overview)
var()detection and fallback parsing case-insensitivevar()and nested fallbacksRelated Issues
Is there anything you'd like reviewers to focus on?