fix: report invalid properties inside nested at-rules #369
+122
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Tanujkanti4441
added
the
accepted
Tanujkanti4441
approved these changes
Jan 26, 2026
Contributor
Tanujkanti4441
left a comment
Tanujkanti4441
left a comment
There was a problem hiding this comment.
LGTM. thanks!
Would like another member to review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This PR fixes an issue where the
no-invalid-propertiesrule failed to report invalid declarations when they were nested inside at-rules (e.g.,@media,@supports) within a style rule.What changes did you make? (Give an overview)
Updated
no-invalid-propertiesrule selectors and added testsRelated Issues
Fixes #363
Is there anything you'd like reviewers to focus on?