chore: update eslint-plugin-eslint-plugin to v7#394
Merged
Conversation
lumirlumir
commented
Mar 10, 2026
| //----------------------------------------------------------------------------- | ||
|
|
||
| /** | ||
| * Represents a property that is supported via @supports. |
Member
Author
There was a problem hiding this comment.
The newly updated eslint-config-eslint@14 now warns about invalid JSDoc patterns that use @. I've updated this PR accordingly, since it was a small change.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repo’s linting tooling to eslint-plugin-eslint-plugin v7 and adjusts the flat-config integration accordingly, aligning with upstream config key changes and updated recommended rules.
Changes:
- Bump
eslint-plugin-eslint-pluginfrom^6.3.2to^7.3.2. - Update
eslint.config.jsto use v7 config keys (dropflat/prefix) and disableeslint-plugin/require-meta-schema-description. - Minor JSDoc formatting tweaks to wrap
@...-prefixed terms in backticks.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/rules/use-baseline.js |
JSDoc text updated to format @supports as code. |
src/languages/css-language.js |
JSDoc text updated to format @eslint/... package references as code. |
package.json |
Updates eslint-plugin-eslint-plugin devDependency to ^7.3.2. |
eslint.config.js |
Switches to v7 config names (rules-recommended, tests-recommended) and disables a newly-recommended rule. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
Changes LGTM, thank you. |
DMartens
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
Note
This PR follows the same pattern used in eslint/json#219.
This PR updates
eslint-plugin-eslint-pluginto the latest v7.According to the changelog, two changes affect us: the
recommendedrules have been updated, and theflat/prefix is no longer necessary.https://github.com/eslint-community/eslint-plugin-eslint-plugin/releases/tag/v7.0.0
The Node.js supported version range now matches what we’ve been using since v7.3.2, so this update appears safe.
What changes did you make? (Give an overview)
This PR updates
eslint-plugin-eslint-pluginto the latest v7.Related Issues
N/A
Is there anything you'd like reviewers to focus on?
I've disabled
eslint-plugin/require-meta-schema-descriptionbecause the schema description doesn't seem particularly useful for our use case. Other feedback is welcome.