-
-
Notifications
You must be signed in to change notification settings - Fork 6
fix: correctly parse nested element selectors #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 21257866981Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
snitin315
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, leaving it open for 2nd review
nzakas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking at this. Can you add a test with a comma in the selector?
main {
p:first-of-type, span {
margin-top: 0;
}
}|
@nzakas Done. |
Prerequisites checklist
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Related Issues
Fix #84
Is there anything you'd like reviewers to focus on?
added tests in css repo as well - eslint/css#349