refactor: simplify no-reversed-media-syntax with ESQuery selector
#498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzakas
deleted the
refactor-simplify-no-reversed-media-syntax-using-esquery-selector
branch
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Hi,
In this PR, I've refactored the
no-reversed-media-syntaxrule, thanks to #469 (review).Previously, we used a separate traversing logic with the
findSkipRangeshelper function. This was somewhat redundant, since ESLint already traverses the AST for us, resulting in duplicate traversing.I've updated the code to use an ESQuery selector instead, which simplifies the traversing logic.
I've also used the
getRangemethod to make the rule more native and switched to theSourceRangedata structure for better consistency.What changes did you make? (Give an overview)
In this PR, I've refactored the
no-reversed-media-syntaxrule, thanks to #469 (review).Related Issues
Ref: #469 (review)
Is there anything you'd like reviewers to focus on?