fix!: remove /types export
#564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
This was referenced Jan 1, 2026
Member
Author
|
I'm marking this PR as ready for review now to align with #561. |
There was a problem hiding this comment.
Pull request overview
This PR removes the /types export from the package, consolidating type exports to the main entry point only. This is a breaking change that simplifies the API by eliminating a redundant export path, as types are already available from @eslint/markdown since PR #520.
Key changes:
- Removed the
./typesexport from package.json's exports field - Types remain accessible via the main entry point (
@eslint/markdown)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nzakas
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
In this PR, I've removed the
/typesexport.This change was mentioned in eslint/json#130 (comment) and was postponed until a breaking change occurred. Now that #561 is pending and introduces such a breaking change, I've opened this PR.
This change is also related to #520, which exports types from the main entry point.
What changes did you make? (Give an overview)
In this PR, I've removed the
/typesexport.This change is a breaking change.
Related Issues
Refs: eslint/json#130 (comment), #520
Is there anything you'd like reviewers to focus on?
N/A