Skip to content

Validate import path #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2025
+9 −4
Merged

Validate import path #1211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions server/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,15 +406,15 @@ func (ctx *BuildContext) buildModule(analyzeMode bool) (meta *BuildMeta, include
return esbuild.OnResolveResult{Path: path}, nil
}

// ban file: imports
if strings.HasPrefix(args.Path, "file:") {
// ban `file:` imports
if after, ok := strings.CutPrefix(args.Path, "file:"); ok {
return esbuild.OnResolveResult{
Path: fmt.Sprintf("/error.js?type=unsupported-file-dependency&name=%s&importer=%s", strings.TrimPrefix(args.Path, "file:"), ctx.esmPath.Specifier()),
Path: fmt.Sprintf("/error.js?type=unsupported-file-dependency&name=%s&importer=%s", after, ctx.esmPath.Specifier()),
External: true,
}, nil
}

// skip data: and http: imports
// skip `data:` and `http:` imports
if strings.HasPrefix(args.Path, "data:") || strings.HasPrefix(args.Path, "https:") || strings.HasPrefix(args.Path, "http:") {
return esbuild.OnResolveResult{
Path: args.Path,
Expand Down Expand Up @@ -546,6 +546,11 @@ func (ctx *BuildContext) buildModule(analyzeMode bool) (meta *BuildMeta, include
filename = path.Join(ctx.wd, "node_modules", specifier)
}

// check if the filename is within the working directory
if !strings.HasPrefix(filename, ctx.wd+string(os.PathSeparator)) {
return esbuild.OnResolveResult{}, fmt.Errorf("could not resolve module %s", specifier)
}

// node native modules do not work via http import
if strings.HasSuffix(filename, ".node") && existsFile(filename) {
return esbuild.OnResolveResult{
Expand Down