Merged
Conversation
Co-Authored-By: 村上雅彦 <m-murakami@esm.co.jp>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
Co-Authored-By: 村上雅彦 <m-murakami@esm.co.jp>
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Co-Authored-By: 村上雅彦 <m-murakami@esm.co.jp>
fossamagna
requested changes
Mar 28, 2025
Comment on lines
+12
to
+19
| <div> | ||
| <Button variant="destructive" type="submit" form="delete-form"> | ||
| Delete | ||
| </Button> | ||
| <form id="delete-form" method="post" className="hidden"> | ||
| <input type="hidden" name="action" value="delete" /> | ||
| </form> | ||
| </div> |
Member
There was a problem hiding this comment.
以下のように、ProjectTechnologyDeleteDialogを作成する前に使っていたダイアログを表示するようにしてください。
Suggested change
| <div> | |
| <Button variant="destructive" type="submit" form="delete-form"> | |
| Delete | |
| </Button> | |
| <form id="delete-form" method="post" className="hidden"> | |
| <input type="hidden" name="action" value="delete" /> | |
| </form> | |
| </div> | |
| <AlertDialog> | |
| <AlertDialogTrigger asChild> | |
| <Button variant="destructive">Delete</Button> | |
| </AlertDialogTrigger> | |
| <AlertDialogContent> | |
| <AlertDialogHeader> | |
| <AlertDialogTitle>Are you sure?</AlertDialogTitle> | |
| <AlertDialogDescription> | |
| This action cannot be undone. This will permanently delete the | |
| technology and remove it from all associated projects. | |
| </AlertDialogDescription> | |
| </AlertDialogHeader> | |
| <AlertDialogFooter> | |
| <AlertDialogCancel>Cancel</AlertDialogCancel> | |
| <form method="post"> | |
| <input type="hidden" name="action" value="delete" /> | |
| <AlertDialogAction | |
| type="submit" | |
| className="bg-destructive text-destructive-foreground hover:bg-destructive/90" | |
| > | |
| Delete | |
| </AlertDialogAction> | |
| </form> | |
| </AlertDialogFooter> | |
| </AlertDialogContent> | |
| </AlertDialog> |
Co-Authored-By: 村上雅彦 <m-murakami@esm.co.jp>
…t technology details navigation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProjectTechnologyの詳細ページを追加
パス:
/project-technologies/:projectTechnologyId実装内容
UIデザインは既存のページと同様のスタイルで実装しています。
Link to Devin run: https://app.devin.ai/sessions/acb2348e1aa2403eadb1f5eb1ab208d8
Requested by: 村上雅彦 (m-murakami@esm.co.jp)