Create overloads to allow float values to be saved in NVS #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅Static analysis result - no issues found! ✅ |
finger563
added
enhancement
finger563
approved these changes
Dec 5, 2024
SquaredPotato
pushed a commit
to smartknob-ha/espp
that referenced
this pull request
Jan 27, 2025
* Create overloads to allow float values to be saved in NVS * Remove test for sizeof float = uint32 * Move implementation from nvs to nvs_handle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added methods to get, get_or_set, and set float values to the ESP NVS system.
Motivation and Context
I needed to store float values and NVS only supports int/uint value storage at this time.
How has this been tested?
Storing and retrieving float values. Used logs to show the storage and retrieval process, also confirmed behavior of firmware to match stored values.
Logs from storage:
Logs from retrieval after hardware reset:
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist: