fix(build): Fix missing include since platform-espressif32 v6.10.0#363
Merged
finger563 merged 1 commit intoesp-cpp:mainfrom Jan 29, 2025
Merged
Conversation
|
✅Static analysis result - no issues found! ✅ |
Contributor
Author
|
Apparently this is happening because of a change in GCC: https://gcc.gnu.org/gcc-14/porting_to.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a missing include to
es8311.hppMotivation and Context
For some reason, only after upgrading to v6.10.0 of platform-espressif32 did we start getting compiler errors on this.
How has this been tested?
First failing pipeline after upgrade:
Pipeline where I've added the
#include <cstdint>:Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.