feat(ble): Update BleGattServer and esp-nimble-cpp submodule#366
Merged
feat(ble): Update BleGattServer and esp-nimble-cpp submodule#366
BleGattServer and esp-nimble-cpp submodule#366Conversation
* Add some new methods to `BleGattServer` * Remove logging from many methods which was unnecessary, and mark those methods `const` * Update `hid_service` example to print Manufacturer name, model number, and PnpId for remote device * Update `hid_service` example to print connected info more clearly and have cleaner code * Update `hid_service` example to wait until after auth to read values from the remote * Update `DeviceInfoService` to have static methods for parsing received PnpId * Update `DeviceInfoService` and `BatteryService` so UUIDs are public * Update `esp-nimble-cpp` submodule to latest, brining in improvements as well as new feature to register store callback for managing bonding info when it fills up. Allows you to read more information from the remotely connected device, if it is supported. Allows you to better control which bonds are deleted / how bonds are managed when the bond storage space fills up * Build and run `hid_service/exmaple` on QtPy ESP32s3 and test with iPhone and Android * Build and run `ble_gatt_server/example` on QtPy ESP32s3 and test with Android.
finger563
added
enhancement
|
✅Static analysis result - no issues found! ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BleGattServerconsthid_serviceexample to print Manufacturer name, model number, and PnpId for remote devicehid_serviceexample to print connected info more clearly and have cleaner codehid_serviceexample to wait until after auth to read values from the remoteDeviceInfoServiceto have static methods for parsing received PnpIdDeviceInfoServiceandBatteryServiceso UUIDs are publicesp-nimble-cppsubmodule to latest, brining in improvements as well as new feature to register store callback for managing bonding info when it fills up.Motivation and Context
Related esp-nimble-cpp PRs included in this change:
How has this been tested?
hid_service/exmapleon QtPy ESP32s3 and test with iPhone and Androidble_gatt_server/exampleon QtPy ESP32s3 and test with Android.Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.