fix(hid-rp): Fix switch pro resetting counter#385
Merged
Conversation
* Fix issue with switch pro hid report `reset()` resetting the counter value, which prevented `increment_counter()` from working * Update switch pro to clear all the report bytes to 0 ensuring subcommand / reply data is zeroed out * remove additional sets in the reset command so app can do it as necessary Fixes an issue specifically with switch compatibility (ios/android didnt seem to care) if you wanted to simplify application code by calling `increment_counter`. * Building and running https://github.com:/finger563/esp-usb-ble-hid with this code and doing longer play session with the switch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
reset()resetting the counter value, which preventedincrement_counter()from workingMotivation and Context
Fixes an issue specifically with switch compatibility (ios/android didn't seem to care) if you wanted to simplify application code by calling
increment_counter. This does not affect code that is already usingset_counterafter callingreset()of course.How has this been tested?
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.