feat(display): Remove display task to instead have lvgl handle it directly#400
Merged
finger563 merged 4 commits intoesp-cpp:mainfrom Mar 9, 2025
Merged
Conversation
|
✅Static analysis result - no issues found! ✅ |
Contributor
|
I've tested this locally within the Please fix the broken examples, then I think this will be good. |
finger563
reviewed
Mar 9, 2025
finger563
approved these changes
Mar 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change removes the update task entirely from the display component, as lvgl can now retrieve its own task ticks.
It also sets the delay callback, so that it can actually delay, rather than doing this.
This should be much more efficient.
Potential downside is that the pause and resume functions can no longer do anything.
The user could still "pause" lvgl by not calling
lv_timer_handler().Motivation and Context
General performance improvements. On programs that actually have a lot of tasks running, the delay callback should free up quite some cpu time.
How has this been tested?
Tested on the Lilygo T-Encoder-Pro and Smartknob-HA.
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.Hardware