Skip to content

feat(vector): Add angle method to get angle between two vectors#404

Merged
finger563 merged 1 commit intomainfrom
feat/vector-angle
Mar 8, 2025
Merged

feat(vector): Add angle method to get angle between two vectors#404
finger563 merged 1 commit intomainfrom
feat/vector-angle

Conversation

@finger563
Copy link
Contributor

Description

  • If T is floating point, then enable angle method to get angle between the two vectors.

Motivation and Context

Consolidates code for computing angle, reducing chances of error and code duplication

How has this been tested?

Building and running as part of https://github.com/finger563/esp-motorgo-mini-gesture-control

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* If `T` is floating point, then enable angle method to get angle between the two vectors.

Consolidates code for computing angle, reducing chances of error and code duplication
@finger563 finger563 self-assigned this Mar 8, 2025
@finger563 finger563 added enhancement New feature or request math labels Mar 8, 2025
@github-actions
Copy link

github-actions bot commented Mar 8, 2025

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit aab998b into main Mar 8, 2025
75 checks passed
@finger563 finger563 deleted the feat/vector-angle branch March 8, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request math

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant