Conversation
…on with user-provided parameters * Update motorgo-mini to allow users to specify their own driver voltages as well as their own motor configurations This allows for a wider variety of use-cases with the motorgo-mini beyond the simple test stand with two bldc drone motors its been designed for up to now. Build and run `motorgo-mini/example` on a motorgo-mini test stand with two little bldc motors to make sure they still work
finger563
added
enhancement
|
✅Static analysis result - no issues found! ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
shared_ptrfor encoders, drivers, and motors. Only allocate them if the relevant functions are called, so that if the user does not want to use them they don't have to waste memory on them.Motivation and Context
Allows more modular and varied use of the MotorGoMini class for the motorgo mini hardware.
How has this been tested?
motorgo-mini/exampleon motorgo mini hardware with two motors.finger563/esp-motorgo-mini-gesture-controlprojectScreenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.