Skip to content

fix(hid-rp): Fix how switch pro reports battery/connection#412

Merged
finger563 merged 1 commit intomainfrom
fix/switch-pro-battery
Mar 28, 2025
Merged

fix(hid-rp): Fix how switch pro reports battery/connection#412
finger563 merged 1 commit intomainfrom
fix/switch-pro-battery

Conversation

@finger563
Copy link
Contributor

Description

  • Fix incorrect ordering of battery and connection info nibbles in switch pro input report.

Motivation and Context

Ensures the battery is properly reported to the switch

How has this been tested?

Build and run as part of esp-usb-ble-hid.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Fix incorrect ordering of battery and connection info nibbles in switch pro input report.

Ensures the battery is properly reported to the switch

Build and run as part of [esp-usb-ble-hid](http://github.com/finger563/esp-usb-ble-hid).
@finger563 finger563 self-assigned this Mar 28, 2025
@finger563 finger563 added bug Something isn't working hid-rp labels Mar 28, 2025
@finger563 finger563 requested a review from Copilot March 28, 2025 13:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • components/hid-rp/include/hid-rp-switch-pro.hpp: Language not supported

@github-actions
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 6d102d8 into main Mar 28, 2025
77 checks passed
@finger563 finger563 deleted the fix/switch-pro-battery branch March 28, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working hid-rp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants