Conversation
|
✅Static analysis result - no issues found! ✅ |
df075ee to
7c2f4ea
Compare
esp_littlefs submodule to littlefs so dependency name is always the same
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
file_system/CMakeLists.txtto havelittlefsbe the dependency name, since that is what it will be when used as a managed componentesp_littlefssubmodule to be namedlittlefsso that it matches the managed component behavior.Motivation and Context
It was found in testing that the file_system component failed to buid when used as a managed component because the
littlfsdependency comes in under the namelittlefs, but the repo was originally designed to useesp_littlefs.How has this been tested?
file_system/example(not managed component) (IDF_COMPONENT_MANAGER=0 idfb)file_system/example(managed component) (idfb)Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.