Skip to content

Fix bound checking in the NorFlash::erase implementation of FlashRegion #4055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix bound checking in the NorFlash::erase implementation of FlashRegion #4055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions esp-bootloader-esp-idf/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- FlashRegion: The `capacity` methods implemented for `embedded_storage::ReadStorage` and `embedded_storage::nor_flash::ReadNorFlash` now return the same value (#3902)
- Don't fail the build on long project names (#3905)
- FlashRegion: Fix off-by-one bug when bounds checking (#3977)
- FlashRegion: Fix exclusive upper bound checking when erasing (#4055)

### Removed

Expand Down
2 changes: 1 addition & 1 deletion esp-bootloader-esp-idf/src/partitions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ where
return Err(Error::OutOfBounds);
}

if !self.range().contains(&address_to) {
if address_to > self.range().end {
return Err(Error::OutOfBounds);
}

Expand Down
Loading