Skip to content

Conversation

JurajSadel
Copy link
Contributor

This workflow is triggered via comment with: /test-size.
It uses

on:
  issue_comment:
    types: [created, edited]

which complicates things a bit and that's why the workflow might be a bit hacky/ugly. To run properly, it firstly needs to be merged into main. I tested it on my fork JurajSadel#12.

closes #4304

@JurajSadel JurajSadel added the skip-changelog No changelog modification needed label Oct 16, 2025
@MabezDev
Copy link
Member

I think a bit more work is required here. We have more than just .stack, .bss and .rodata so we should also be asking bloaty to check these. Also the formatting on the comments in your PR seem a bit off, layout-wise.

@JurajSadel
Copy link
Contributor Author

I think a bit more work is required here. We have more than just .stack, .bss and .rodata so we should also be asking bloaty to check these.

This should be handled by bloaty I'm not specifying anything. I it shows sections when they are changed, when I didn't add anything to FLASH, .rodata was not printed. So I guess it should be fine 🤞

@JurajSadel
Copy link
Contributor Author

Also the formatting on the comments in your PR seem a bit off, layout-wise.

I will play with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog No changelog modification needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

We could have a way (CI or xtask) that compares sizes of a few examples to that of the last release

2 participants