Fix some UART-related issues #4586
Draft
+70
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/hil full |
|
Triggered full HIL run for #4586. Run: https://github.com/esp-rs/esp-hal/actions/runs/19830655480 Status update: ❌ HIL (full) run failed (conclusion: failure). |
bugadani
force-pushed
the
uart-changes
branch
from
4ad6928 to
bed8a12
Compare
MabezDev
reviewed
Dec 2, 2025
bugadani
force-pushed
the
uart-changes
branch
2 times, most recently
from
38406fe to
2be16bc
Compare
bugadani
force-pushed
the
uart-changes
branch
from
2be16bc to
ef47d58
Compare
bugadani
force-pushed
the
uart-changes
branch
from
ef47d58 to
6c02337
Compare
Contributor
Author
|
/hil full |
|
Triggered full HIL run for #4586. Run: https://github.com/esp-rs/esp-hal/actions/runs/19865042209 Status update: ❌ HIL (full) run failed (conclusion: failure). |
bugadani
force-pushed
the
uart-changes
branch
from
fd07a6e to
1f46865
Compare
|
I just tested the current commit of your branch |
Contributor
Author
|
Thank you, I'll spend time to try and better reproduce this issue. In the mean time, can you try changing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes three changes to the UART driver:
It stabilizesWill be proposed separately.read_readyand expands on its documentation, to make it possible to truly read without blocking.wait_for_buffered_datain an attempt to fixread_exact_asyncreturnsFifoOverflowedwhen more than 128 bytes is to be received #4523@jimy-byerley could you please see if this PR addresses your issue? It's not easy to reproduce on the MCU itself, and I'm not sure if we can make a reliable test case for it.