Skip to content

refactor: add must_use to event loop handles #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
domodwyer wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: add must_use to event loop handles #574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
149caa1
refactor: add must_use to event loop handles
domodwyer Apr 6, 2025
717c0fb
refactor: remove EventLoopHandle must_use
domodwyer Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- OTA: Allow specifying image size to speed up erase
- Bluetooth: New methods `EspBleGap::start_scanning` and `EspBleGap::stop_scanning`
- New example, `bt_ble_gap_scanner` to demonstrate usage of added ble scanning methods
- Add #[must_use] annotations to event loop types with drop handlers.

## [0.51.0] - 2025-01-15

Expand Down
1 change: 1 addition & 0 deletions src/eventloop.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,7 @@ where
}
}

#[must_use = "Event subscription is unregistered when handle is dropped"]
pub struct EspSubscription<'a, T>
where
T: EspEventLoopType,
Expand Down