Skip to content

Conversation

@kpcyrd
Copy link
Contributor

@kpcyrd kpcyrd commented Jan 14, 2025

Fixes the following currently present in 3.3.0:

   Doc-tests espflash
warning: unknown attribute `no-run`
  --> espflash/src/cli/monitor/external_processors.rs:2:1
   |
2  | / //! External processor support
3  | | //!
4  | | //! Via the command line argument `--processors` you can instruct espflash to run external executables to p...
5  | | //! the logs received from the target. Multiple processors are supported by separating them via `,`. Proces...
...  |
41 | | //! }
42 | | //! ```
   | |_______^
   |
   = help: use `no_run` to compile, but not run, the code sample during testing
   = help: this code block may be skipped during testing, because unknown attributes are treated as markers for code samples written in other programming languages, unless it is also explicitly marked as `rust`
   = note: `#[warn(rustdoc::invalid_codeblock_attributes)]` on by default

warning: 1 warning emitted


running 1 test
test espflash/src/cli/monitor/external_processors.rs - cli::monitor::external_processors (line 17) ... FAILED

failures:

---- espflash/src/cli/monitor/external_processors.rs - cli::monitor::external_processors (line 17) stdout ----
Test executable failed (exit status: 101).

stderr:
thread 'main' panicked at espflash/src/cli/monitor/external_processors.rs:6:36:
index out of bounds: the len is 1 but the index is 1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@jessebraham jessebraham added the skip-changelog Skips the changelog CI check label Jan 14, 2025
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jessebraham jessebraham added this pull request to the merge queue Jan 14, 2025
Merged via the queue into esp-rs:main with commit 85d8f31 Jan 14, 2025
28 of 29 checks passed
@kpcyrd kpcyrd deleted the fix-no_run branch January 14, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Skips the changelog CI check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants