fix: resolve type mismatch for mbed_tls_version return type#113
Merged
ivmarkov merged 1 commit intoesp-rs:mainfrom Mar 8, 2026
Merged
fix: resolve type mismatch for mbed_tls_version return type#113ivmarkov merged 1 commit intoesp-rs:mainfrom
ivmarkov merged 1 commit intoesp-rs:mainfrom
Conversation
The return type is currently hard-coded to `u32`, but the actual type of `mbedtls_ssl_protocol_version` is an enum, which is subject to the `short-enum` pitfall.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The return type is currently hard-coded to
u32, but the actual type ofmbedtls_ssl_protocol_versionis an enum, which is not necessarily 32 bits wide.I discovered this issue thanks to the CI failure on esp-rs/openthread#64:
https://github.com/esp-rs/openthread/actions/runs/22805574122/job/66154038284