Only export LIBCLANG_PATH when export=true#38
Merged
SergioGasquez merged 2 commits intoesp-rs:mainfrom Feb 17, 2025
Merged
Conversation
This is primarily useful for hands-off environments where the paths are not exported by default (otherwise, downstream actions would need to hard-code this action's choice of export file), and conveniently allows eliding the parameter during installation (because the variable is used by espup).
4 tasks
chrysn
added a commit
to chrysn-pull-requests/ariel-os
that referenced
this pull request
Feb 17, 2025
With [38] tentatively in (through a branched action), [491] can be reverted; the latter had doing something like [38] in its list of considered alternatives, but failed to foresee the need for sourcing all that data back in for compiling C code on Xtensa. [38]: esp-rs/xtensa-toolchain#38 [491]: ariel-os#491
chrysn
added a commit
to chrysn-pull-requests/ariel-os
that referenced
this pull request
Feb 17, 2025
With [38] tentatively in (through a branched action), [491] can be reverted; the latter had doing something like [38] in its list of considered alternatives, but failed to foresee the need for sourcing all that data back in for compiling C code on Xtensa. [38]: esp-rs/xtensa-toolchain#38 [491]: ariel-os#491
Contributor
Author
|
I've now also tested this on the Ariel OS CI infrastructure, running its full build tests that cover different ESPs but also non-ESP MCUs. Moreover, this enables building mixed C and Rust programs (as tested in ariel-os/ariel-os#826; the failed tests there are just because there are merge commits in its history), something that we could not do in a mixed environment before. |
Closed
chrysn
added a commit
to chrysn-pull-requests/ariel-os
that referenced
this pull request
Feb 17, 2025
With [38] tentatively in (through a branched action), [491] can be reverted; the latter had doing something like [38] in its list of considered alternatives, but failed to foresee the need for sourcing all that data back in for compiling C code on Xtensa. [38]: esp-rs/xtensa-toolchain#38 [491]: ariel-os#491
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a solution to #35 that does not interfere with any existing deployments by creating a new option; it is an alternative to #36 and somehow builds on #37 (it doesn't strictly depend on #37, but any user of this will want #37 in).