Disconnect only if the ESP has connected before #2708
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've tried scanning function in ESP many times with many ESPs and every time they stop functioning and crashed. So I checked line by line and found out that this disconnect upon no connection is the one causing it. So I added the control block and now they're working fine!
Current coverage is 27.80% (diff: 100%)@@ master #2708 diff @@
==========================================
Files 20 20
Lines 3625 3625
Methods 335 335
Messages 0 0
Branches 656 656
==========================================
Hits 1008 1008
Misses 2441 2441
Partials 176 176
|
|
@devyte, does this still make sense? Looks to me to be a race condition (there's some small chance WiFi IRQ will get connection between Also, I thought this kind of thing was fixed w/the IRQ stack fixes recently implemented. |
|
Maybe you're right, but then calling disconnect when there is no prior connection should be tested. if thst doesn't crash, just close this. |
|
I just tested, and calling WiFi.disconnect() without a prior connection doesn't crash with latest git. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried the scanning function in ESP many times with many ESPs and every time they stop functioning and crashed. So I checked line by line and found out that this disconnect() upon no connection is the one causing it. So I added the control block to see if there is any connection and now they're working fine!