Skip to content

Also catch OSError when trying to set TCP_QUICKACK #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2025
Merged

Also catch OSError when trying to set TCP_QUICKACK #1093

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3df964f
Also catch OSError when trying to set TCP_QUICKACK
badrpc Mar 2, 2025
6303189
Update connection.py
bdraco Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aioesphomeapi/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ async def _connect_socket_connect(self, addrs: list[hr.AddrInfo]) -> None:
sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1)
try:
sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_QUICKACK, 1) # type: ignore[attr-defined, unused-ignore]
except AttributeError:
except (AttributeError, OSError): # On FreeBSD this may throw OSError
_LOGGER.debug(
"%s: TCP_QUICKACK not supported",
self.log_name,
Expand Down