Skip to content

Conversation

@rwrozelle
Copy link
Contributor

@rwrozelle rwrozelle commented Jan 29, 2026

What does this implement/fix?

Adds the attribute server_keepalive_interval to HelloResponse and use it to update the connections _keep_alive_interval, after HelloResponse. This allows the server(device) to define the interval.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

  • fixes

Pull request in esphome (if applicable):

Pull request in esphome-docs with documentation (if applicable):

Checklist:

  • The code change is tested and works locally.
  • If api.proto was modified, a linked pull request has been made to esphome with the same changes.
  • Tests have been added to verify that the new code works (under tests/ folder).
    Need help on updating tests, not sure how they are done.

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.94%. Comparing base (5717d4a) to head (d7d0c1a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
aioesphomeapi/connection.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main    #1490      +/-   ##
===========================================
- Coverage   100.00%   99.94%   -0.06%     
===========================================
  Files           23       23              
  Lines         3506     3509       +3     
===========================================
+ Hits          3506     3507       +1     
- Misses           0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 29, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing rwrozelle:api-Configurable-Keep-Alive-Timeout (d7d0c1a) with main (5717d4a)1

Summary

✅ 11 untouched benchmarks

Footnotes

  1. No successful run was found on main (284b33b) during the generation of this report, so 5717d4a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant