Allow to disable the phase balancer for PCA9685 #5157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The PCA9685 chip allows for flexible phase angles. Currently the component uses this ability to set the phase angles equidistantly for all output channels. So 3 output channels would have a phase angle of 0°, 120° and 240°. This however can cause flickering of the LEDs when animating / fading, because when the output changes and the start angle is higher than the end angle of the output the chip will need an additional frame where no signal is outputted (as indicated by the (datasheet)[https://cdn-shop.adafruit.com/datasheets/PCA9685.pdf#page=20]
This pull requests documents a new configuration option
phase_balancerwith the options oflinear, which keeps the current behavior and is the default. Andnonewhich sets all phase angles to 0°, so that the problem described above does not happen.Pull request in esphome with YAML changes (if applicable):
Checklist:
I am merging into
nextbecause this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/components/index.rstwhen creating new documents for new components or cookbook.