-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update AM2320 documentation with frequency note #5522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jablikcz
wants to merge
1
commit into
esphome:current
Choose a base branch
from
jablikcz:patch-1
base: current
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -17,16 +17,26 @@ The `am2320` Temperature+Humidity sensor allows you to use your AM2320 | |||||
| > [!NOTE] | ||||||
| > Logs might include some warnings about receiving a NACK from the sensor. | ||||||
| > This is due to a wake call to the sensor which the sensor never acknowledges by design. | ||||||
| > Sensor works on BUS frequency up to 100kHz, but by default is 200kHz in use. So decrease will help with sensor reliability. | ||||||
|
|
||||||
| ```yaml | ||||||
| # Example configuration entry | ||||||
| i2c: | ||||||
| - id: bus_a | ||||||
| sda: GPIO4 | ||||||
| scl: GPIO5 | ||||||
| scan: true | ||||||
| frequency: 50000 | ||||||
|
||||||
| frequency: 50000 | |
| frequency: 50000 # 50kHz - recommended for AM2320 reliability |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The note should explain why 50kHz is recommended when the sensor supports up to 100kHz. Consider revising to: 'The sensor supports I2C bus frequencies up to 100kHz. ESPHome's default frequency is 200kHz, which may cause reliability issues. Setting the frequency to 50kHz (well below the maximum) ensures stable operation.'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know the default is 50kHz? Where do you see a default of 200?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just see there in the logs from some esp device. Maybe this is the default in some sensor library. Lets change the notes as needed.