[climate] Document public accessor methods for custom modes in 2025.11.0 release#5653
[climate] Document public accessor methods for custom modes in 2025.11.0 release#5653clydebarrow merged 2 commits intocurrentfrom
Conversation
…1.0 release notes
There was a problem hiding this comment.
As this is a feature matched with a PR in https://github.com/esphome/esphome, please target your PR to the next branch and rebase.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
WalkthroughDocumentation and API docs updated for the Climate component: the public string properties Changes
Sequence Diagram(s)(This change is documentation/API signature-only; no control-flow diagram applicable.) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
As this is a feature matched with a PR in https://github.com/esphome/esphome, please target your PR to the next branch and rebase.
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
Documents public accessor methods for Climate entity custom modes introduced in ESPHome 2025.11.0, replacing direct member access patterns.
- Added migration guide in release notes showing transition from
optionalmember access to accessor methods - Updated Climate component documentation to show new accessor methods (
has_custom_fan_mode(),get_custom_fan_mode(),has_custom_preset(),get_custom_preset()) - Added nullptr safety warning with correct/incorrect usage examples
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| content/changelog/2025.11.0.md | Added YAML lambda migration examples and updated developer breaking changes to document accessor methods |
| content/components/climate/_index.md | Removed deprecated direct member access examples and added new accessor methods section with nullptr safety warning |
There was a problem hiding this comment.
As this is a feature matched with a PR in https://github.com/esphome/esphome, please target your PR to the next branch and rebase.
Description:
This PR adds missing documentation for the Climate entity's public accessor methods (
has_custom_fan_mode(),get_custom_fan_mode(),has_custom_preset(),get_custom_preset()) that were introduced in PR #11621.Changes Made:
Release Notes (2025.11.0.md) - YAML Lambda Changes Section
custom_fan_mode.has_value()/custom_fan_mode.value()to the new accessor methodsRelease Notes - Breaking Changes for Developers Section
Climate Entity Documentation (
content/components/climate/_index.md)custom_fan_modeandcustom_presetfrom the attributes listTechnical Details:
The changes document the API transition from:
optional<std::string> custom_fan_mode(public member, direct access)const char* custom_fan_mode_(private member, accessor methods)Related issue (if applicable): N/A
Pull request in esphome with YAML changes (if applicable):
Checklist:
I am merging into
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/components/index.rstwhen creating new documents for new components or cookbook. (N/A - updating existing documentation)