Skip to content

Conversation

@tomaszduda23
Copy link
Contributor

@tomaszduda23 tomaszduda23 commented Nov 11, 2025

What does this implement/fix?

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

  • fixes

Pull request in esphome-docs with documentation (if applicable):

  • esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx
  • nRF52840

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

esphome/esphome-docs#5596

@github-actions
Copy link
Contributor

To use the changes from this PR as an external component, add the following to your ESPHome configuration YAML file:

external_components:
  - source: github://pr#11841
    components: [nrf52]
    refresh: 1h

(Added by the PR bot)

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.39%. Comparing base (661920c) to head (5765f38).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #11841      +/-   ##
==========================================
- Coverage   72.43%   72.39%   -0.04%     
==========================================
  Files          53       53              
  Lines       11134    11134              
  Branches     1504     1504              
==========================================
- Hits         8065     8061       -4     
- Misses       2677     2680       +3     
- Partials      392      393       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@esphome esphome bot removed the needs-docs label Nov 11, 2025
@bdraco bdraco changed the title [nrf52]add settings for dcdc converter [nrf52] add settings for dcdc converter Nov 12, 2025
@bdraco
Copy link
Member

bdraco commented Nov 12, 2025

Please see comments on the linked docs PR

@tomaszduda23
Copy link
Contributor Author

Please see comments on the linked docs PR

Thanks for checking. It has been fixed.

@bdraco bdraco merged commit d869108 into esphome:dev Nov 13, 2025
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants