refactor: endpoint for pdf generation#231
Merged
danielnottingham merged 3 commits intomainfrom Jan 13, 2025
Merged
Conversation
edimossilva
reviewed
Jan 13, 2025
Member
edimossilva
left a comment
edimossilva
left a comment
There was a problem hiding this comment.
LGTM,
- Main suggestion is to extract the numbers to variables, you can make it at class level or you can centralize all of them on a single place
- Another thing is that I feel like all the report data should come from one place and later on, we pass it to the pdf, I looked really quickly and didn't confirm it is like this, but look like it is not.
edimossilva
reviewed
Jan 13, 2025
…df_reports_controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.