Skip to content

Fixes the HealthInsurence#index to return true and false custom values. #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielnottingham merged 5 commits into from
Feb 13, 2025
Merged

Fixes the HealthInsurence#index to return true and false custom values. #238

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d241abb
Fixes the HealthInsurence#index to return true and false custom values.
mattfeg Feb 12, 2025
485bfae
Fixes HealthInsurence specs to include custom param.
mattfeg Feb 12, 2025
bbb5283
Adds specs for HealthInsurance::List on users filter for correctly re…
mattfeg Feb 13, 2025
e6155d8
Fixes linting offenses.
mattfeg Feb 13, 2025
f22fc3b
Fixes HealthInsurance::List specs for a valid test.
mattfeg Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/operations/health_insurances/list.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def apply_custom_filter(query)
if %w[true false].include?(params[:custom])
query.by_custom(custom: params[:custom], user: user)
else
query.where(custom: false)
query.where(user: user)
end
end
end
Expand Down
5 changes: 3 additions & 2 deletions spec/requests/api/v1/health_insurances_request_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@

before do
headers = auth_token_for(create(:user))
get "/api/v1/health_insurances", headers: headers
params = { custom: false }
get "/api/v1/health_insurances", headers: headers, params: params
end

it "returns ok" do
Expand Down Expand Up @@ -62,7 +63,7 @@
before do
create_list(:health_insurance, 8)
headers = auth_token_for(create(:user))
get "/api/v1/health_insurances", params: { page: 2, per_page: 5 }, headers: headers
get "/api/v1/health_insurances", params: { page: 2, per_page: 5, custom: false }, headers: headers
end

it "returns only 3 health_insurances" do
Expand Down