Skip to content

Refacts apartment_multiplier to use constants instead magic numbers #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielnottingham merged 1 commit into from
Mar 18, 2025
Merged

Refacts apartment_multiplier to use constants instead magic numbers #250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/operations/event_procedures/build_total_amount_cents.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ class BuildTotalAmountCents < Actor

URGENCY_PERCENTAGE = 0.3
ANESTHETIC_PORT_ZERO_AMOUNT = "3"
APARTMENT_FACTOR = 2
STANDARD_FACTOR = 1

def call
self.total_amount_cents = (base_amount_cents + urgency_amount.to_i) * apartment_multiplier
Expand Down Expand Up @@ -47,7 +49,7 @@ def find_port_value(cbhpm_procedure)
end

def apartment_multiplier
event_procedure.apartment? ? 2 : 1
event_procedure.apartment? ? APARTMENT_FACTOR : STANDARD_FACTOR
end

def urgency_amount
Expand Down
Loading