Added shared context for unauthenticated access#253
Merged
edimossilva merged 1 commit intoespoo-dev:mainfrom Apr 5, 2025
Merged
Conversation
edimossilva
requested changes
Apr 1, 2025
Member
edimossilva
left a comment
edimossilva
left a comment
There was a problem hiding this comment.
The actual codebase has many places where the context you are creating can be reused.
You should apply it everywhere.
edimossilva
reviewed
Apr 2, 2025
edimossilva
reviewed
Apr 2, 2025
edimossilva
reviewed
Apr 2, 2025
edimossilva
requested changes
Apr 3, 2025
…ts tests test: add shared context for unauthenticated access shared_context 'when user is not authenticated' added to some request tests refactored tests using shared_context 'when user is not authenticated' shared context 'when user is not authenticated' applied in all requests tests shared context 'when user is not authenticated' applied in all requests tests test: add shared context for unauthenticated access shared_context 'when user is not authenticated' added to some request tests refactored tests using shared_context 'when user is not authenticated' shared context 'when user is not authenticated' applied in all requests tests
lucasleandro1
force-pushed
the
test/add-shared-context-unauthenticated
branch
from
0e42196 to
f35d90e
Compare
lucasleandro1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This task introduces a 'shared context' for handling unauthenticated user requests in request tests. Instead of repeating the same authentication failure checks, we now reuse the shared context across multiple tests, for this was created shared_context 'when user is not authenticated'`.
fix #220