Created validation for when urgency and custom both true#268
Merged
edimossilva merged 6 commits intoespoo-dev:mainfrom Apr 16, 2025
Merged
Conversation
Contributor
Author
|
With this validation created, the rspec test ./spec/operations/event_procedures/create_spec.rb:96 was broken, as it has urgency and custom true |
edimossilva
reviewed
Apr 9, 2025
edimossilva
reviewed
Apr 9, 2025
edimossilva
requested changes
Apr 10, 2025
…into feat/validate-eventprocedure-urgency-custom
Contributor
Author
|
In test spec/operations/event_procedures/create_spec.rb:96 the urgency value was changed from true to false in the test, as the current validation prevents custom procedures from being marked as urgent. The change ensures that the test simulates a valid creation. |
edimossilva
reviewed
Apr 14, 2025
…ckend into feat/validate-eventprocedure-urgency-custom
lucasleandro1
changed the title
lucasleandro1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation of the EventProcedure model to ensure that it is not possible to create records where both the urgency field and the custom attribute of the associated procedure are set to true.
fix #256