Validation to not allow have patient with different user #278
Merged
edimossilva merged 8 commits intoespoo-dev:mainfrom Apr 28, 2025
Merged
Conversation
edimossilva
requested changes
Apr 15, 2025
…ckend into fix-validation-eventprocedure-unique-user
2e45275 to
f67423e
Compare
edimossilva
requested changes
Apr 18, 2025
…ckend into fix-validation-eventprocedure-unique-user
edimossilva
reviewed
Apr 28, 2025
app/models/event_procedure.rb
Outdated
| def match_user_with_patient_user | ||
| return if patient.nil? || user.nil? | ||
|
|
||
| return unless patient.user_id != user_id |
Member
There was a problem hiding this comment.
Avoid using unless together with negation
Suggested change
| return unless patient.user_id != user_id | |
| return if patient.user_id == user_id |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation of the EventProcedure model to ensure that there is no patient with different user
fix #96